Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix documented type for the cleanUrl option #1775

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

Vinnl
Copy link
Contributor

@Vinnl Vinnl commented Sep 5, 2019

Motivation

The documented type was wrong, I think.

Have you read the Contributing Guidelines on pull requests?

Well, I have now.

Test Plan

I must admit I haven't verified it because it's so trivial, but build the docs and visit /docs/en/site-config#cleanurl-string.

Related PRs

-

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 5, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 32e5975

https://deploy-preview-1775--docusaurus-2.netlify.com

1 similar comment
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 32e5975

https://deploy-preview-1775--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 32e5975

https://deploy-preview-1775--docusaurus-preview.netlify.com

@Vinnl
Copy link
Contributor Author

Vinnl commented Sep 5, 2019

That doesn't seem to work: https://deploy-preview-1775--docusaurus-preview.netlify.com/docs/en/site-config#cleanurl-string

I'm not sure why though?

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Many thanks!

@yangshun yangshun changed the title Fix documented type for the cleanUrl option docs: fix documented type for the cleanUrl option Sep 13, 2019
@yangshun yangshun merged commit a585324 into facebook:master Sep 13, 2019
@Vinnl Vinnl deleted the patch-1 branch September 14, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants