Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer links margin #1781

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Conversation

blackredscarf
Copy link
Contributor

@blackredscarf blackredscarf commented Sep 12, 2019

Motivation

See #1776

Have you read the Contributing Guidelines on pull requests?

Yes, I have.

Test Plan

NA

Related PRs

NA

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 12, 2019

Deploy preview for docusaurus-2 failed.

Built with commit 77b6073

https://app.netlify.com/sites/docusaurus-2/deploys/5d7bf7dd3112cb0008cf54b5

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 12, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 77b6073

https://deploy-preview-1781--docusaurus-preview.netlify.com

@yangshun yangshun changed the title fix footer links margin fix: footer links margin Sep 13, 2019
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I changed the CSS to remove the margins as they were redundant.

@yangshun yangshun merged commit a16e346 into facebook:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants