-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document docker is optional #1848
Conversation
Added a note that Docker files were not needed, and they may be deleted.
Hi EricPonvelle! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
I'm really bad at adding copyright notices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the file to include copyright as well as my intended message.
Deploy preview for docusaurus-2 ready! Built with commit ab6f81f |
Deploy preview for docusaurus-preview ready! Built with commit ab6f81f |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Deploy preview for docusaurus-preview ready! Built with commit 1ba00e9 |
Deploy preview for docusaurus-2 ready! Built with commit 1ba00e9 |
Fixed a styling issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed a styling issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Added a note that Docker files were not needed, and they may be deleted.
fix #1110
Motivation
Clarify that some files may be deleted.
Have you read the Contributing Guidelines on pull requests?
Yes.