Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document docker is optional #1848

Merged
merged 4 commits into from
Oct 17, 2019
Merged

docs: document docker is optional #1848

merged 4 commits into from
Oct 17, 2019

Conversation

EricPonvelle
Copy link
Contributor

@EricPonvelle EricPonvelle commented Oct 17, 2019

Added a note that Docker files were not needed, and they may be deleted.

fix #1110

Motivation

Clarify that some files may be deleted.

Have you read the Contributing Guidelines on pull requests?

Yes.

Added a note that Docker files were not needed, and they may be deleted.
@facebook-github-bot
Copy link
Contributor

Hi EricPonvelle! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

I'm really bad at adding copyright notices.
Copy link
Contributor Author

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the file to include copyright as well as my intended message.

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit ab6f81f

https://deploy-preview-1848--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit ab6f81f

https://deploy-preview-1848--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 17, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@endiliey
Copy link
Contributor

endiliey commented Oct 17, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 1ba00e9

https://deploy-preview-1848--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 17, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 1ba00e9

https://deploy-preview-1848--docusaurus-2.netlify.com

Copy link
Contributor Author

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a styling issue.

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@endiliey endiliey changed the title Update getting-started-installation.md docs: document docker is optional Oct 17, 2019
@endiliey endiliey merged commit 3086bbf into facebook:master Oct 17, 2019
@EricPonvelle EricPonvelle deleted the patch-2 branch October 17, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that Docker is optional?
4 participants