fix(v2): fix build caused when one tab item #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit db31721 |
|
Deploy preview for docusaurus-preview ready! Built with commit db31721 |
yangshun
reviewed
Nov 5, 2019
yangshun
approved these changes
Nov 5, 2019
|
Will there be 2.0.0-alpha.33 for this? |
|
Personally, I don't think it's very urgent because only users having one item will run into this and they can choose not to upgrade to 2.0.0-alpha.32 yet. @endiliey is our release guy and he could release one if it isn't too much work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hotfix: after the .32 release, if there is one code tab, then the build command will fail.
Actually, my fault, this error didn’t exist when the devserver was working, but something did not work when compiling the build :(
Probably we need tests that the build command checks.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See #1934 and apply build.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)