chore: bump dev dependencies #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
commented
Nov 9, 2019
| @@ -21,5 +21,7 @@ module.exports = { | |||
| plugins: [ | |||
| '@babel/plugin-proposal-class-properties', | |||
| '@babel/plugin-proposal-object-rest-spread', | |||
| '@babel/plugin-proposal-nullish-coalescing-operator', | |||
There was a problem hiding this comment.
Otherwise jest won't be able to handle TS 3.7 nullish and optional chaining later on. (babel-preset-typescript doesnt include that)
| "eslint": "4.x", | ||
| "eslint-config-airbnb": "17.1.0", | ||
| "eslint-config-prettier": "^2.9.0", | ||
| "babel-eslint": "^10.0.3", |
There was a problem hiding this comment.
Don't know why its been so long since last bump :o
| "jest": "^24.9.0", | ||
| "lerna": "^3.18.1", | ||
| "lerna-changelog": "^0.8.2", | ||
| "lint-staged": "^7.2.0", | ||
| "picomatch": "^2.1.0", | ||
| "prettier": "^1.18.2", | ||
| "prettier": "^1.19.0", |
| @@ -33,6 +33,10 @@ module.exports = { | |||
| 'react/button-has-type': OFF, // 1 | |||
| 'react/forbid-prop-types': OFF, // 1 | |||
| 'react/require-default-props': OFF, // 1 | |||
| 'jsx-a11y/control-has-associated-label': OFF, // 1 | |||
There was a problem hiding this comment.
Some of the eslint plugins are updated and stricter. So turning it off
| @@ -75,5 +75,11 @@ | |||
| "tiny-lr": "^1.1.1", | |||
| "tree-node-cli": "^1.2.5", | |||
| "truncate-html": "^1.0.3" | |||
| }, | |||
| "devDependencies": { | |||
There was a problem hiding this comment.
All of this is specific to v1 only
endiliey
added
the
pr: maintenance
|
Deploy preview for docusaurus-preview ready! Built with commit 2e9999f |
|
Deploy preview for docusaurus-2 ready! Built with commit 2e9999f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bump dev dependencies such as eslint, etc. Also moved some dev deps to its respective package. Root dev deps should be more for something like
lerna, @types, and eslintHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
CI should all pass