Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): remove empty containers when no data in blog pages #1963

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 12, 2019

Motivation

If there is no previous or next post, then extra space appears due to vertical margins. The same goes for the container with tags and read more link.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Extra spaces when empty content:

image

image

No extra spaces:

image

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 12, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 97a114c

https://deploy-preview-1963--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 97a114c

https://deploy-preview-1963--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix ;)

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops meant to approve it.

@yangshun yangshun merged commit 3df601c into facebook:master Nov 12, 2019
@yangshun yangshun added the pr: bug fix This PR fixes a bug in a past release. label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants