Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): move header inside article tag in doc page #1975

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 12, 2019

Motivation

In terms of semantics, the header tag should be inside the article tag, rather not outside it.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See HTML markup, no UI changes.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Nov 12, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 12, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 5866d81

https://deploy-preview-1975--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 5866d81

https://deploy-preview-1975--docusaurus-2.netlify.com

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc it was intentional because of algolia crawling. @s-pace can you give some insight whether

tag should be inside ?

@yangshun yangshun merged commit 2493583 into facebook:master Nov 13, 2019
@s-pace
Copy link

s-pace commented Nov 13, 2019

It works for us. We can adapt the template config accordingly. Thanks @endiliey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants