refactor(v2): split out dark mode toggle so it is easily swizzle-able #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit 78ff7d3 |
|
Deploy preview for docusaurus-preview ready! Built with commit 78ff7d3 |
endiliey
force-pushed
the
endi/toggle
branch
from
f795991 to
78ff7d3
Compare
|
should we take this chance to migrate the hook to an observer then? |
|
Feel free to takeover PR or send a new one if u prefer :). I am not sure if I can create a resilient and good observer hook for this. I like @lex111 approach using simple subscription method. This PR is only splitting out the component so someone can switch the toggle out to something else. Like how I changed the sun moon icon in endiliey.com |
wgao19
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some refactoring ... Split components out.
Some people might want a different toggle ...
Feel free to close if this is not needed
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan