Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add meta generator docusaurus #2014

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Nov 19, 2019

Motivation

Add meta generator tag according to HTML5 spec like v1
https://html.spec.whatwg.org/multipage/semantics.html#standard-metadata-names

Benefits:

  • Wappalyzer chrome extension can detect us

wappalyzer

- You can search for popular website created with docusaurus easily eg: https://publicwww.com/websites/%22%3Cmeta+name%3Dgenerator+content%3DDocusaurus%3E%22/

image

Have you read the Contributing Guidelines on pull requests?

yes

@endiliey endiliey requested a review from yangshun as a code owner November 19, 2019 08:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 19, 2019
@endiliey endiliey added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 19, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit b1a388b

https://deploy-preview-2014--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit b1a388b

https://deploy-preview-2014--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo good good!

@yangshun yangshun merged commit 6595f00 into master Nov 20, 2019
@yangshun yangshun deleted the endi/metagenerator branch November 20, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants