breaking(v2): minimum required nodejs version 8.9->8.10 so we can use es2017 #2045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Node >= 8.10.0 support 100% ES2017 with native async await
while
Node 8.9.0 only support 100% ES6, 100% ES2016 and 73% ES2017.
Because of this, previously our TypeScript compiler always have to compile to ES6 and polyfill the await function.
For example, our generated js files for docusaurus/core/src/server/index is like this previously
After compiling to ES2017, it can utilize node's own native async await which is more optimized
Extra benefit is that our npm package should be lower in size due to removal of polyfills
Anyway, node 8.X is going for EOL this 31 December 2019. I think most people is in v10 or v12 anyway
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan