Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(v2): use webpack future version of asset emitting logic to free memory #2046

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Nov 25, 2019

Motivation

Implement webpack/webpack#8642 which is webpack@5 default behavior to emit assets.

Nextjs, nuxtjs set this option too for memory friendly performance.

Inspired from https://nextjs.org/blog/webpack-memory

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

  • Local dev ok
  • [] Netlify
  • [] CI

@endiliey endiliey added the pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. label Nov 25, 2019
@endiliey endiliey requested a review from yangshun as a code owner November 25, 2019 05:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 25, 2019
@endiliey endiliey changed the title perf(v2): use webpack future version of asset emitting logic to free … perf(v2): use webpack future version of asset emitting logic to free memory Nov 25, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit b1635c6

https://deploy-preview-2046--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit b1635c6

https://deploy-preview-2046--docusaurus-preview.netlify.com

@yangshun yangshun merged commit 2607e86 into master Nov 25, 2019
@endiliey endiliey deleted the endi/memory branch November 26, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants