fix: transpile static js to IE 10 #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Nov 27, 2019
| @@ -5,57 +5,64 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
|
|
|||
| /* eslint-disable prefer-arrow-callback */ | |||
There was a problem hiding this comment.
This is required to prevent ESLint rule auto fix like prefer-shorthand.
|
Deploy preview for docusaurus-2 ready! Built with commit 89b7667 |
|
Deploy preview for docusaurus-preview ready! Built with commit 89b7667 |
endiliey
changed the title
yangshun
approved these changes
Nov 28, 2019
|
@yangshun Yeah. If the team does plan to change these files often, we can use If we are not going to change these files, then I would say just leave it as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transpile static JavaScript files to IE 10 support so that they does not bail on IE 10.
This Babel REPL is broken on IE 11 due to the client JavaScript requires ES6.
Have you read the [Contributing Guidelines on pull requests] (https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md#pull-requests)?
Yep
Test Plan
Manually testing the generated website.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)