Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(v1): fix props for ProjectTitle #2083

Merged
merged 2 commits into from
Dec 4, 2019
Merged

refactor(v1): fix props for ProjectTitle #2083

merged 2 commits into from
Dec 4, 2019

Conversation

FeynmanDNA
Copy link
Contributor

@FeynmanDNA FeynmanDNA commented Dec 3, 2019 •
edited by yangshun
Loading

Fixes #2082

@facebook-github-bot
Copy link
Contributor

Hi FeynmanDNA! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Dec 3, 2019 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 16a69c2

https://deploy-preview-2083--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Dec 3, 2019 •
edited
Loading

Deploy preview for docusaurus-preview ready!

Built with commit 16a69c2

https://deploy-preview-2083--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 3, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun changed the title v1 website index.js fix props for ProjectTitle refactor(v1): fix props for ProjectTitle Dec 4, 2019
yangshun
yangshun approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I made some modifications to not pass the entire siteConfig in so that the ProjectTitle doesn't have access to unnecessary props it doesn't use directly.

@yangshun yangshun added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 4, 2019
@yangshun yangshun merged commit e042535 into facebook:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@endiliey endiliey Awaiting requested review from endiliey

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V1 Example Page/Index.js ProjectTitle Component Does Not Have Props
4 participants
@FeynmanDNA @facebook-github-bot @docusaurus-bot @yangshun