fix(v2): metadata error if markdown does not have ending line #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
approved these changes
Dec 6, 2019
|
MDX... |
|
My bad.. I should've been more careful and take this into account. Glad I find this out in my blog |
|
Deploy preview for docusaurus-2 ready! Built with commit 4a10087 |
|
Deploy preview for docusaurus-preview ready! Built with commit 4a10087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If markdown file does not have an ending line, the metadata embed in content will error out due to MDX mistaking
export const metadataas part of paragraphExample:
This won't error
Error
So whats happening under the hood ?
The metadata is mistaken as part of paragraph
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
No more error
Related PRs
#2088