feat(v2): better & nice looking error overlay #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: maintenance
endiliey
commented
Dec 6, 2019
| // TODO: add plugins beforeDevServer and afterDevServer hook | ||
| }, | ||
| }; | ||
| WebpackDevServer.addDevServerEntrypoints(config, devServerConfig); |
There was a problem hiding this comment.
No longer needed cause we dont want to use the default client from webpack-dev-server. We use CRA's
|
Deploy preview for docusaurus-2 ready! Built with commit 9ef1235 |
|
Deploy preview for docusaurus-preview ready! Built with commit 9ef1235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Better error overlay.
Previously it's like this
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Hot reload still ok
Error, can even open editor like CRA
