Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): escape import path on windows #2099

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Dec 7, 2019

Motivation

Continuation from #2086 Still one part not yet stringified. Seems that I didn't push it to remote

Edit: maybe I need a break 😢 , silly mistake
Close #2098

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

image

@endiliey endiliey requested a review from yangshun as a code owner December 7, 2019 02:45
@endiliey endiliey added the pr: bug fix This PR fixes a bug in a past release. label Dec 7, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 7, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 15fb648

https://deploy-preview-2099--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 15fb648

https://deploy-preview-2099--docusaurus-preview.netlify.com

@endiliey endiliey merged commit 5c39041 into master Dec 7, 2019
@endiliey endiliey deleted the endi/escapeimport branch December 7, 2019 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example Site in Install Instructions Failing on Windows
3 participants