fix(v2): remove style-loader, use minicssextract in both dev & prod #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit bf316f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #2143
Close #2141
Remove
style-loaderand its annoying bug and useMiniCssExtractPluginfor both development and production environment.The main reasons to use style-loader in development mode previously is to support hot module reloading but MiniCssExtractPlugin which is used for production build does support HMR feature since v0.6.0 (2019-04-10).
This ensures consistency
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Local hmr still working
Production build styles should work OK (Netlify)