Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix plugin-content-docs config comment typo #2216

Merged
merged 1 commit into from
Jan 15, 2020
Merged

docs(v2): fix plugin-content-docs config comment typo #2216

merged 1 commit into from
Jan 15, 2020

Conversation

sdowding
Copy link
Contributor

copy/pasted comment referred to "blogs" not "docs".

Motivation

I was reading the docs and got confused :)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related PRs

N/A

copy/pasted comment refered to "blogs" not "docs".
@sdowding sdowding requested a review from yangshun as a code owner January 15, 2020 04:02
@facebook-github-bot
Copy link
Contributor

Hi sdowding! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit d9d7545

https://deploy-preview-2216--docusaurus-2.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 15, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@wgao19 wgao19 changed the title fix plugin-content-docs config comment typo docs(v2): fix plugin-content-docs config comment typo Jan 15, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yangshun yangshun merged commit d7bc0b9 into facebook:master Jan 15, 2020
@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants