Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): render correct theme for live code blocks on SSR #2227

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 18, 2020

Motivation

Currently, the correct syntax theme is not applied to live code blocks, if you go not through client navigation (for example, open a link directly). This PR fixes this.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Compare current version (https://v2.docusaurus.io/docs/markdown-features/) with preview one.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 18, 2020
@lex111 lex111 requested a review from yangshun January 18, 2020 12:25
@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jan 18, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit d031b4d

https://deploy-preview-2227--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks >.<

@yangshun yangshun merged commit 95caf83 into facebook:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants