Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): avoid to use raw theme values #2254

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 30, 2020

Motivation

A simple small refactoring in the useTheme hook, in order to avoid using of raw values ('' and 'dark') for the theme in the code base. It seems to me that it has become more understandable and easier.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Make sure theme switching works as before.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from yangshun January 30, 2020 06:33
@lex111 lex111 requested a review from wgao19 as a code owner January 30, 2020 06:33
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 30, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit be9cc82

https://deploy-preview-2254--docusaurus-2.netlify.com

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 30, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! You rock!

@yangshun
Copy link
Contributor

Did some brief testing on Netlify preview. Looks good.

@yangshun yangshun merged commit ab25ee3 into facebook:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants