Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add title for Feedback page #2256

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 30, 2020

Motivation

The page should contain a meaningful title.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Check meta title on Feedback page.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from yangshun January 30, 2020 14:04
@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 30, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 30, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 30, 2020

Deploy preview for docusaurus-2 ready!

Built with commit de9ac24

https://deploy-preview-2256--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangshun yangshun merged commit 2cc4111 into facebook:master Jan 30, 2020
@yangshun yangshun deleted the title-fb branch January 30, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants