Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): require using JSX flavored style objects in mdx #2257

Merged
merged 2 commits into from
Feb 1, 2020

Conversation

wgao19
Copy link
Contributor

@wgao19 wgao19 commented Jan 30, 2020

…ttributes in Docusaurus 2

Motivation

Resolving #2252, add docs about v2 requiring use of JSX flavored style object syntax as opposed to style attributes in v1.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Preview

Related PRs

NA

@wgao19 wgao19 requested a review from yangshun as a code owner January 30, 2020 15:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 30, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 30, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 582e99c

https://deploy-preview-2257--docusaurus-2.netlify.com

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 31, 2020
Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much Wei!

@yangshun yangshun merged commit e224361 into master Feb 1, 2020
@yangshun yangshun deleted the wgao19/docs/diff-style-objects branch February 9, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants