Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(v2): clean up comments in code #2294

Merged
merged 1 commit into from
Feb 18, 2020
Merged

misc(v2): clean up comments in code #2294

merged 1 commit into from
Feb 18, 2020

Conversation

yangshun
Copy link
Contributor

Motivation

Was taking a brief look at the code and decided to just reformat some comments. The only code change here is to deprecate @docusaurus/utils in packages/docusaurus/client/export because it is confusing to have the same package name although one refers to the monorepo package (in Node) and the other refers to the webpack alias (in client-side JS)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI and preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 18, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit a9cfa79

https://deploy-preview-2294--docusaurus-2.netlify.com

@yangshun yangshun merged commit 996b115 into master Feb 18, 2020
@yangshun yangshun deleted the comments branch February 18, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants