fix(v2): properly set dark mode logo on build-time prerendering #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit ec182a5 |
yangshun
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
This triggers a remounting of the component right? I think it's fine but I'm wondering if we should create dark-mode aware Image components, possibly building on top of IdealImage. That would be useful for logo and other places as well (index page, documentation).
I envision it to work like:
<AwesomeImage src="..." darkModeSrc="..." />
and we switch the image path depending on the current mode.
yangshun
changed the title
|
Probably yes, we need to think in this direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #2308.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The same as for #2261 but in addition to build the website and see that the logos are displayed correctly.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)