Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): mark tagline field as optional #2342

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 28, 2020

Motivation

Resolve #1969

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Remove tagline field and try build website.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 28, 2020
@lex111 lex111 requested a review from yangshun February 28, 2020 13:45
@lex111 lex111 requested a review from wgao19 as a code owner February 28, 2020 13:45
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 28, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Feb 28, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 854289d

https://deploy-preview-2342--docusaurus-2.netlify.com

@lex111 lex111 force-pushed the tagline-optional-field branch from 02e82f9 to 854289d Compare February 28, 2020 13:49
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yangshun yangshun merged commit 3cbee86 into master Feb 29, 2020
@yangshun yangshun deleted the tagline-optional-field branch February 29, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tagline and favicon should not be required fields
4 participants