Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add note about edits in versioned docs #2368

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 6, 2020

Motivation

We often encounter some misunderstanding of versioned docs by contributors - they document new changes in versioned docs and/or fix typos only in versioned docs. It seems to me that I need to somehow clarify this.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

GitHub.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 6, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 2019473

https://deploy-preview-2368--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be helpful and I hope more users read the CONTRIBUTING.md. I feel that many of them don't read :/

Another idea I had was to inject an admonition in __DEV__ only and warn them in the UI of the current version of the docs, that would be hard to miss.

@yangshun yangshun merged commit 03791ce into master Mar 7, 2020
@yangshun yangshun deleted the lex111-patch-1 branch March 7, 2020 03:11
@lex111
Copy link
Contributor Author

lex111 commented Mar 7, 2020

This is actually a good task for @docusaurus-bot!

@yangshun yangshun added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants