-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): suggest Surge for quick deployment #2408
Conversation
This is a much cleaner PR without some confusing changes . I made edits to the docs and also focused on the changes you requested |
Deploy preview for docusaurus-2 ready! Built with commit 33c412c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not add this to versioned docs, IMO.
@lex111 I would love to know why if you don't mind, maybe something is wrong with the way I wrote it that needs to be corrected, would love to get your feedback. |
@fakela because only fixes should be made to versioned docs, not a new info. |
Thanks @lex111 for explaining why I have removed the fixes from the versioned docs and only left it in website/docs/deployment.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation
My motivation was to include how Surge can also be used to deploy docusaurus project in a matter of minutes.
I thought it would be a good idea to have Docusaurus users take advantage of this, so I added it to the docs.
Steps:
npx @docusaurus/init@next init my-website classic
surge build/
if you have a domain name
surge build/ yourdomain.com
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
usage described in the section above. pretty easy. Also, an example of a docusaurus app deployed using surge
(http://panicky-observation.surge.sh/)