Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): suggest Surge for quick deployment #2408

Merged
merged 8 commits into from
Mar 23, 2020
Merged

Conversation

fakela
Copy link
Contributor

@fakela fakela commented Mar 13, 2020

Motivation

My motivation was to include how Surge can also be used to deploy docusaurus project in a matter of minutes.
I thought it would be a good idea to have Docusaurus users take advantage of this, so I added it to the docs.
Steps:
npx @docusaurus/init@next init my-website classic
surge build/
if you have a domain name
surge build/ yourdomain.com

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

usage described in the section above. pretty easy. Also, an example of a docusaurus app deployed using surge
(http://panicky-observation.surge.sh/)

@fakela fakela requested review from wgao19 and yangshun as code owners March 13, 2020 23:46
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 13, 2020
@fakela
Copy link
Contributor Author

fakela commented Mar 13, 2020

This is a much cleaner PR without some confusing changes . I made edits to the docs and also focused on the changes you requested

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 13, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 33c412c

https://deploy-preview-2408--docusaurus-2.netlify.com

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add this to versioned docs, IMO.

@fakela
Copy link
Contributor Author

fakela commented Mar 16, 2020

@lex111 I would love to know why if you don't mind, maybe something is wrong with the way I wrote it that needs to be corrected, would love to get your feedback.

@lex111
Copy link
Contributor

lex111 commented Mar 17, 2020

@fakela because only fixes should be made to versioned docs, not a new info.

@fakela
Copy link
Contributor Author

fakela commented Mar 17, 2020

Thanks @lex111 for explaining why I have removed the fixes from the versioned docs and only left it in website/docs/deployment.md

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 21, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yangshun yangshun merged commit cdfab94 into facebook:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants