Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add support dark logo for sidebar logo #2434

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 21, 2020

Motivation

Resolve #2430

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Specify path to logo for dark mode in themeConfig.navbar.logo.srcDark option.
  2. Make sure that dark logo is displayed when dark mode is turned on

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Mar 21, 2020
@lex111 lex111 requested review from wgao19 and yangshun as code owners March 21, 2020 19:53
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 21, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 7a556d0

https://deploy-preview-2434--docusaurus-2.netlify.com

@yangshun yangshun merged commit 5358fca into master Mar 22, 2020
@yangshun yangshun deleted the lex111/iss2430 branch March 22, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar hideOnScroll: true shows light mode logo in dark mode
4 participants