Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(v2): add logo for dark mode #2439

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 22, 2020

Motivation

Just use dogfooding practice.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Make sure that a different logo is displayed in dark mode (Slash with keyboard).

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 22, 2020
@lex111 lex111 requested a review from yangshun as a code owner March 22, 2020 07:28
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 22, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 5510490

https://deploy-preview-2439--docusaurus-2.netlify.com

@yangshun
Copy link
Contributor

This is so cute! Awesome!

@yangshun yangshun merged commit 5b08ba7 into master Mar 22, 2020
@yangshun yangshun deleted the lex111/internal-dark-logo branch March 22, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants