feat(v2): add TypeScript support for theme components #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit a953aaf |
fanny
approved these changes
Mar 26, 2020
lex111
approved these changes
Mar 27, 2020
lex111
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to write swizzled theme components in TypeScript. (I'm not sure whether the maintainers of docusaurus want to eventually convert
@docusaurus/theme-classiccomponents into typescript.)The infrastructure for typescript is already mostly setup in #2221 and #2310. This diff just adds support for recognizing typescript files for theme component.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
packages/docusaurus-theme-classic/src/theme/Footer/index.js's extension to tsx. Tryyarn start. It will fail by saying@theme/Footercannot be resolved.yarn startagain. Now@theme/Footeris correctly resolved and the page will load successfully.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)