Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add ability to create unminimized bundles #2474

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 28, 2020

Motivation

Resolve https://docusaurus.canny.io/admin/board/feature-requests/p/minifying-option

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn build --no-minify and make sure any JS bundle is not minified.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: new feature This PR adds a new API or behavior. label Mar 28, 2020
@lex111 lex111 added this to the v2.0.0-alpha.49 milestone Mar 28, 2020
@lex111 lex111 requested a review from yangshun March 28, 2020 22:53
@lex111 lex111 requested a review from wgao19 as a code owner March 28, 2020 22:53
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 28, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 482876c

https://deploy-preview-2474--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we change the flag to minify with default of true?

@lex111
Copy link
Contributor Author

lex111 commented Mar 29, 2020

You can specify a boolean option long name with a leading no- to set the option value to false when used. Defined alone this also makes the option true by default.

https://www.npmjs.com/package/commander#other-option-types-negatable-boolean-and-flagvalue

Therefore, when running the yarn build command, the minify parameter will be true (and false if --no-minify flag is specified).

@yangshun yangshun merged commit fa2e263 into master Mar 29, 2020
@yangshun yangshun deleted the lex111/no-uglify-flag branch March 29, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants