Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): make correct Open Graph title for doc page #2475

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 28, 2020

Motivation

I noticed that OG title it is wrong for the doc page:

image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview - https://deploy-preview-2475--docusaurus-2.netlify.com/docs/theme-classic/

image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Mar 28, 2020
@lex111 lex111 added this to the v2.0.0-alpha.49 milestone Mar 28, 2020
@lex111 lex111 requested a review from yangshun March 28, 2020 23:19
@lex111 lex111 requested a review from wgao19 as a code owner March 28, 2020 23:19
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 28, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit b9ba0d0

https://deploy-preview-2475--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you!

@yangshun yangshun merged commit cffb3f9 into master Mar 29, 2020
@yangshun yangshun deleted the lex111/og-title-doc-page branch March 29, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants