Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix HTML issues nav dropdown and highlight docs item #2489

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 1, 2020

Motivation

  • Fix warnings about props
  • Add missed li element in dropdown
  • Make non-clickable parent nav link of dropdown menu
  • Fix highlight "Docs" menu item

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 1, 2020
@lex111 lex111 requested review from wgao19 and yangshun as code owners April 1, 2020 10:29
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 1, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 38dc448

https://deploy-preview-2489--docusaurus-2.netlify.com

@lex111 lex111 added this to the v2.0.0-alpha.50 milestone Apr 1, 2020
@yangshun yangshun merged commit 1577ab9 into master Apr 1, 2020
@yangshun yangshun deleted the lex111/fix-navbar-dropdown branch April 1, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants