fix(v2): Use writeFileSync to write generated sitemap.xml to avoid early termination
#2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…early termination
|
Deploy preview for docusaurus-2 ready! Built with commit 83a5146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2516.
Without a synchronous write, the callback may never be invoked because it's killed by
process.exitintroduced in #2443.Motivation
Unbreak sitemap generation.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Since I wasn't able to produce a repro for the docusaurus repo but I was able to repro it on my repo (see #2516), so I made the test against my repo.
yarnto compile all files.packages/docusaurus-plugin-sitemap/lib/index.jsinto correct place in https://github.com/SamChou19815/website 'snode_modulesyarn workspace blog buildin https://github.com/SamChou19815/website, now the sitemap is correctly generated.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)