refactor(v2): replace Lodash with single methods packages in utils #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
approved these changes
Apr 5, 2020
yangshun
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit c6c80fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is probably the last PR in Lodash series from me. This PR replaces
lodashpackage indocusaurus-utilswhich also allows to remove@types/lodashfrom the workspacepackage.json.There may by one more PR which cleans things up, but I need to fix my
yarn buildfirst.lodashpackage cannot be remove from workspacepackage.jsonbecause V1 is still using it.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Same test results before and after code refactor.
Related PRs
#2460
#2519
#2520
#2529
#2535