Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): upgrade devDependencies #2538

Merged
merged 3 commits into from
Apr 5, 2020
Merged

chore(v2): upgrade devDependencies #2538

merged 3 commits into from
Apr 5, 2020

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Apr 5, 2020

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@yangshun yangshun changed the title Yarn chore(v2): upgrade devDependencies Apr 5, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 5, 2020
@@ -23,7 +23,7 @@
"unist-util-visit": "^2.0.2"
},
"devDependencies": {
"remark": "^11.0.2",
"remark": "^12.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think all of these deps shouldn't be under devDependencies...

@yangshun yangshun requested review from lex111 and wgao19 as code owners April 5, 2020 10:59
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 1786d0a

https://deploy-preview-2538--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 2627d45

https://deploy-preview-2538--docusaurus-2.netlify.com

@yangshun yangshun merged commit b07507c into master Apr 5, 2020
@yangshun yangshun added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 5, 2020
@lex111 lex111 deleted the yarn branch April 5, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants