Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): use synchronous write for generate blog feeds #2540

Merged
merged 5 commits into from
Apr 5, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 5, 2020

Motivation

Fix #2539 (see similar issue #2516)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Build website and make sure that the build/blog/atom.xml and build/blog/rss.xml files are not empty.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 5, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 5, 2020
@lex111 lex111 requested a review from yangshun April 5, 2020 14:19
@lex111 lex111 requested a review from wgao19 as a code owner April 5, 2020 14:21
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 43d6eec

https://deploy-preview-2540--docusaurus-2.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 5, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 5, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 99ba0b2

https://deploy-preview-2540--docusaurus-2.netlify.com

@yangshun yangshun merged commit 5eba5f2 into master Apr 5, 2020
@lex111 lex111 deleted the lex111/fix-blog-feed-gen branch April 5, 2020 15:11
mohrash92 pushed a commit to mohrash92/docusaurus that referenced this pull request Apr 11, 2020
* fix(v2): use synchronous write for generate blog feeds

* FIx code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] RSS feed generation seems broken
4 participants