Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): be more polite #2566

Merged
merged 2 commits into from
Apr 9, 2020
Merged

docs(v2): be more polite #2566

merged 2 commits into from
Apr 9, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 9, 2020

Motivation

It seems to me that docs should not use constructs that contain "you should", this is somehow not entirely polite for our users.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Only for master-docs.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 9, 2020
@lex111 lex111 requested a review from yangshun April 9, 2020 07:17
@lex111 lex111 requested a review from wgao19 as a code owner April 9, 2020 07:17
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 9, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 9, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 1f21226

https://deploy-preview-2566--docusaurus-2.netlify.com

@@ -9,7 +9,7 @@ To build the static files of your website for production, run:
npm run build
```

Once it finishes, you should see the production build under the `build/` directory.
Once it finishes, you might want to see the production build under the `build/` directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not about telling the user what to do. This is more of telling the user what to expect. I think we can change it to "you will" instead.

@yangshun yangshun merged commit 7092daf into master Apr 9, 2020
@yangshun yangshun deleted the lex111/docs-polite branch April 9, 2020 07:29
@yangshun
Copy link
Contributor

yangshun commented Apr 9, 2020

If we want to improve our docs overall we can use alex. I tried it before but it was kinda noisy and too many to fix so I didn't follow through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants