Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): treat mailto and tel links properly #2579

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 11, 2020

Motivation

Resolve #2568

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Use the similar elements as the item link in navbar and footer.

        {
          label: 'Mailto link',
          href: 'mailto:foo@bar.com',
          position: 'right',
        },
            {
              label: 'Telephone link',
              href: 'tel:+1234567890',
              position: 'right',
            },

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 11, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 11, 2020
@lex111 lex111 requested a review from yangshun as a code owner April 11, 2020 09:10
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 11, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 57a8184

https://deploy-preview-2579--docusaurus-2.netlify.com

@yangshun yangshun merged commit 399fcbd into master Apr 11, 2020
@yangshun yangshun deleted the lex111/tel-mail-links branch April 11, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(v2): href links in Footer append a leading slash to mailto: links
5 participants