Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): use nav link component only where needed #2585

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 11, 2020

Motivation

As mentioned in #2580 (comment), this will allow clean things up with nav links, in other words, it’s now clearer where we need to use the functionality of nav links, in their original purpose*.

* A special version of the that will add styling attributes to the rendered element when it matches the current URL.

This basically removes unnecessary DOM attrs related with highlighting (via CSS) the current link (for our needs, this is only necessary for navbar and doc sidebar).

This is potentially BC change, although it seems unlikely that anyone used this functionality, especially since it would not work by default except in the navbar and doc sidebar (because the according CSS styles for the active menu item are defined only for these specified components).
And in general, it is not clear where this can be useful to the end user, so this is absolutely unnecessary functionality for them.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 11, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 11, 2020
@lex111 lex111 requested a review from yangshun April 11, 2020 22:53
@lex111 lex111 requested a review from wgao19 as a code owner April 11, 2020 22:53
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 11, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit a40a9f7

https://deploy-preview-2585--docusaurus-2.netlify.com

@yangshun yangshun merged commit 9c1abcd into master Apr 12, 2020
@lex111 lex111 deleted the lex111/link-router branch April 12, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants