feat(v2): add ability set dark mode by default #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 6a4a30e |
fanny
reviewed
Apr 13, 2020
yangshun
approved these changes
Apr 14, 2020
website/docs/theme-classic.md
Outdated
| module.exports = { | ||
| // ... | ||
| themeConfig: { | ||
| forceDarkMode: true, |
There was a problem hiding this comment.
defaultDarkMode would be a better name IMO. forceDarkMode sounds like we're forcing the site to be permanently in dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #2565 and corresponding request on Canny (https://docusaurus.canny.io/admin/board/feature-requests/p/default-to-dark-theme)
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Make sure that there is no saved proffered theme in local storage (
themekey) and add thethemeConfig.forceDarkMode=trueoption in the config file.Now when you open the website, dark mode will be turned on (light mode can be selected via navbar toggle)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)