Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): inherit color for announcement bar close icon #2602

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 14, 2020

Motivation

On a recently added project in Showcase I noticed that the announcement bar close icon is hard to see when using a dark color, see an example below

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

https://graphql-inspector.com/docs/index

Before:

image

After:

image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 14, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 14, 2020
@lex111 lex111 requested review from wgao19 and yangshun as code owners April 14, 2020 11:49
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 14, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 6b3666a

https://deploy-preview-2602--docusaurus-2.netlify.com

@yangshun yangshun merged commit 6a2fdbe into master Apr 14, 2020
@lex111 lex111 deleted the lex111/announcement-bar-close-icon branch April 14, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants