Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade shelljs to 0.8.4 #2661

Merged
merged 1 commit into from
Apr 25, 2020
Merged

chore: upgrade shelljs to 0.8.4 #2661

merged 1 commit into from
Apr 25, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 25, 2020

Motivation

Resolve #2648

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Install Node.js v14.0.0 and run the yarn start command - there should be no any warnings in the console output.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 25, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 25, 2020
@lex111 lex111 requested a review from yangshun as a code owner April 25, 2020 15:59
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 25, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit b55364c

https://deploy-preview-2661--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@yangshun yangshun merged commit 8730df7 into master Apr 25, 2020
@lex111 lex111 deleted the lex111/chore-shelljs branch April 26, 2020 06:33
@fishcharlie
Copy link

Any insight into when this might make it into an alpha release?

@lex111
Copy link
Contributor Author

lex111 commented Apr 26, 2020

Tomorrow, according to our plans, there should be a new release, but I can’t promise this for sure, since the decision not only depends on me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js v14 Warning: Accessing non-existent property ___ of module exports inside circular dependency
5 participants