Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): upgrade prism-react-renderer to latest version #2666

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 26, 2020

Motivation

Resolve #2655

I wrote an email to author of prism-react-renderer so that he could accept bunch a PRs and after a few hours he updated the lib, very fast!

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

After that, Python decorator highlighting works fine (although this is not supported by all themes), and then Palenight theme now has diff syntax support.

снимок_8

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 26, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 26, 2020
@lex111 lex111 requested a review from yangshun as a code owner April 26, 2020 16:41
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 26, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit ba1ad89

https://deploy-preview-2666--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for pushing prism-react-renderer along as well!

@yangshun yangshun merged commit 379d3e0 into master Apr 26, 2020
@yangshun yangshun deleted the lex111/prism branch April 26, 2020 16:50
@omry
Copy link

omry commented Apr 26, 2020

Awesome, thanks!

@kitten
Copy link

kitten commented Apr 26, 2020

@lex111 let me know if you need anything else. I consider prism-react-renderer as Esther stable as the entire Prism implementation can be swapped out for edge cases, but the new version did upgrade the vendored Prism, so let me know if anything else goes wrong 👍

@omry
Copy link

omry commented Apr 26, 2020

Thanks for the quick reaction @kitten!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python syntax highlighting in a code block is inconsistent
6 participants