Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): upgrade Infima to 0.2.0-alpha.10 #2729

Merged
merged 2 commits into from
May 10, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 9, 2020

Motivation

The latest version of Infima has been extensively refactoring, so we need to update it.

For the test, I generated a website built of Redux (https://goofy-murdock-b8f04d.netlify.app/) - everything looks fine (except for pagination links, but this is OK because, because I just replaced the CSS file according latest version of Infima).

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

View pages of preview and Redux site with new version of Infima (https://goofy-murdock-b8f04d.netlify.app/)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 9, 2020
@lex111 lex111 requested a review from yangshun May 9, 2020 18:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 9, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 9, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 2c4c1db

https://deploy-preview-2729--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to release notes too about the renaming

@lex111
Copy link
Contributor Author

lex111 commented May 10, 2020

Done ✔️

@yangshun yangshun merged commit 93b39e6 into master May 10, 2020
@yangshun yangshun deleted the lex111/upd-infima branch May 10, 2020 13:03
@lex111 lex111 added this to the v2.0.0-alpha.55 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants