Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): make external links more secure #2783

Merged
merged 1 commit into from
May 22, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 21, 2020

Motivation

For security reasons, it is recommended that we add the optional rel="noopener noreferrer" attribute for external links.
Beside this, external links in navbar/footer have the same behavior.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See #2780

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 21, 2020
@lex111 lex111 requested a review from yangshun as a code owner May 21, 2020 19:01
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 21, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 78a089a

https://deploy-preview-2783--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs too Alexey!

@yangshun yangshun merged commit 7448501 into master May 22, 2020
@lex111 lex111 deleted the lex111/secure-external-link branch May 22, 2020 07:07
@lex111 lex111 added this to the v2.0.0-alpha.56 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants