Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): increase search input on medium screens #2799

Merged
merged 3 commits into from
May 24, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 23, 2020

Motivation

A follow-up and based on #2791.

On medium screens (tablets) it makes sense to increase the search input width, similar to mobiles screens.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before:

screenshot_6

After:

screenshot_5

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 23, 2020
@lex111 lex111 requested a review from yangshun as a code owner May 23, 2020 07:17
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 23, 2020
@@ -35,6 +35,7 @@ const Search = ({handleSearchBarToggle, isSearchBarExpanded}) => {
openOnFocus: true,
autoselect: false,
hint: false,
tabAutocomplete: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This produces extra CSS classes, especially since this option is not fit for us.

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 8199bef

https://deploy-preview-2799--docusaurus-2.netlify.app

@yangshun yangshun merged commit 604f9f5 into master May 24, 2020
@yangshun yangshun deleted the lex111/search-input-medium-screens branch May 24, 2020 04:45
@lex111 lex111 added this to the v2.0.0-alpha.56 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants