Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): make proper h1 font size on mobiles #2800

Merged
merged 1 commit into from
May 24, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 23, 2020

Motivation

According to Infima styles https://github.com/facebookincubator/infima/blob/master/packages/core/styles/content/markdown.css#L36-L41

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label May 23, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 23, 2020
@lex111 lex111 requested a review from yangshun May 23, 2020 07:58
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 8916995

https://deploy-preview-2800--docusaurus-2.netlify.app

@lex111
Copy link
Contributor Author

lex111 commented May 23, 2020

Test fails because this:

 FAIL  packages/**********-1.x/lib/server/__tests__/utils.test.js (78.747s)
  server utils
    ✕ minify css (5634ms)
    ✓ autoprefix css (68ms)
    ✓ getLanguage (4ms)
    ✓ getSubdir (5ms)

  ● server utils › minify css
>     : Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Error:

Curious, should we increase the timeout for build of v1?

@yangshun yangshun merged commit b52b7d6 into master May 24, 2020
@yangshun
Copy link
Contributor

Let's see if the timeout error still persists.

@yangshun yangshun deleted the lex111/h1-size-mobiles branch May 24, 2020 12:09
@lex111 lex111 added this to the v2.0.0-alpha.56 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants