Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): align search icon to center on mobiles #2814

Merged
merged 1 commit into from
May 27, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 27, 2020

Motivation

See Test plan.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
screenshot_7 screenshot_8

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 27, 2020
@lex111 lex111 requested a review from yangshun as a code owner May 27, 2020 08:24
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 27, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 90db1bf

https://deploy-preview-2814--docusaurus-2.netlify.app

@yangshun yangshun merged commit f23d03b into master May 27, 2020
@lex111 lex111 deleted the lex111/search-icon-center branch May 27, 2020 11:04
@lex111 lex111 added this to the v2.0.0-alpha.56 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants