feat(v2): allow skipping build docs for next version #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 5cfb3db |
slorber
reviewed
Jun 4, 2020
slorber
reviewed
Jun 4, 2020
…ocusaurus into lex111/docs-skip-next-release
|
cc @yangshun |
|
lgtm |
|
Thanks a lot for bringing this feature from V1. Will this also generate the sitemap without the next release docs if the option is enabled? I couldn't tell from the changes in this PR. |
|
yes the next paths should not appear in the sitemaps because we don't add any react router route for the next paths (which are read by the sitemaps plugin) Tell me if this does not work for you once we release |
|
Perfect!! Thank you. Will try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #2813
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
docsset theexcludeNextVersionDocsfield with thetruevalue.yarn startand make sure that docs are accessible bydocs/nextpathyarn buildand make surebuild/docs/nextdir does not exist.excludeNextVersionDocsfiled and build site again, and make surebuild/docs/nextdir appears.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)